search

NREL / reV

Renewable Energy Potential (reV) Model
https://nrel.github.io/reV/
BSD 3-Clause "New" or "Revised" License
107 stars 24 forks source link

Bnb/dev #394

Closed bnb32 closed 1 year ago

bnb32 commented 1 year ago

Added write_mapped_gids flag so the project point gids will be written to output meta instead of the resource gids.

codecov-commenter commented 1 year ago

Codecov Report

Base: 80.85% // Head: 80.90% // Increases project coverage by +0.04% :tada:

Coverage data is based on head (14e744f) compared to base (067be4a). Patch coverage: 83.33% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #394 +/- ## ========================================== + Coverage 80.85% 80.90% +0.04% ========================================== Files 143 143 Lines 19916 19945 +29 ========================================== + Hits 16104 16137 +33 + Misses 3812 3808 -4 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `80.90% <83.33%> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/NREL/reV/pull/394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL) | Coverage Δ | | |---|---|---| | [reV/generation/cli\_gen.py](https://codecov.io/gh/NREL/reV/pull/394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL2dlbmVyYXRpb24vY2xpX2dlbi5weQ==) | `59.03% <42.85%> (-0.38%)` | :arrow_down: | | [reV/config/sam\_analysis\_configs.py](https://codecov.io/gh/NREL/reV/pull/394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL2NvbmZpZy9zYW1fYW5hbHlzaXNfY29uZmlncy5weQ==) | `88.46% <100.00%> (+0.27%)` | :arrow_up: | | [reV/generation/generation.py](https://codecov.io/gh/NREL/reV/pull/394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL2dlbmVyYXRpb24vZ2VuZXJhdGlvbi5weQ==) | `86.02% <100.00%> (+0.22%)` | :arrow_up: | | [tests/test\_gen\_wind.py](https://codecov.io/gh/NREL/reV/pull/394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-dGVzdHMvdGVzdF9nZW5fd2luZC5weQ==) | `90.72% <100.00%> (+0.31%)` | :arrow_up: | | [reV/losses/scheduled.py](https://codecov.io/gh/NREL/reV/pull/394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL2xvc3Nlcy9zY2hlZHVsZWQucHk=) | `100.00% <0.00%> (ø)` | | | [reV/losses/power\_curve.py](https://codecov.io/gh/NREL/reV/pull/394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL2xvc3Nlcy9wb3dlcl9jdXJ2ZS5weQ==) | `98.86% <0.00%> (+<0.01%)` | :arrow_up: | | [reV/config/project\_points.py](https://codecov.io/gh/NREL/reV/pull/394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL2NvbmZpZy9wcm9qZWN0X3BvaW50cy5weQ==) | `85.41% <0.00%> (+0.04%)` | :arrow_up: | | [reV/handlers/collection.py](https://codecov.io/gh/NREL/reV/pull/394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL2hhbmRsZXJzL2NvbGxlY3Rpb24ucHk=) | `80.11% <0.00%> (+0.05%)` | :arrow_up: | | [tests/test\_hybrids.py](https://codecov.io/gh/NREL/reV/pull/394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-dGVzdHMvdGVzdF9oeWJyaWRzLnB5) | `96.43% <0.00%> (+0.23%)` | :arrow_up: | | [reV/config/base\_config.py](https://codecov.io/gh/NREL/reV/pull/394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL2NvbmZpZy9iYXNlX2NvbmZpZy5weQ==) | `84.92% <0.00%> (+0.24%)` | :arrow_up: | | ... and [6 more](https://codecov.io/gh/NREL/reV/pull/394?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

grantbuster commented 1 year ago

Code-wise it LGTM. Before merging, we should make sure there is no other way to achieve this behavior. Maybe @grantbuster can chime in?

I think this is fine, @ppinchuk do you have a concern that i'm not seeing? The gid_map is kind of a hack and I think it makes sense that we do the replacement in the meta data property where the gid_map takes place.

ppinchuk commented 1 year ago

Code-wise it LGTM. Before merging, we should make sure there is no other way to achieve this behavior. Maybe @grantbuster can chime in?

I think this is fine, @ppinchuk do you have a concern that i'm not seeing? The gid_map is kind of a hack and I think it makes sense that we do the replacement in the meta data property where the gid_map takes place.

No concerns, I think this is good. Just wanted to make sure to get your eyes on it too. I've only used gid_map once I think, so you'd be more familiar with it than I am