codecov-commenter
commented
1 year ago Codecov Report
Patch coverage: 94.73% and project coverage change: +0.15 :tada:
Comparison is base (
7c8dfdf) 81.37% compared to head (4569b57) 81.53%.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #410 +/- ## ========================================== + Coverage 81.37% 81.53% +0.15% ========================================== Files 144 144 Lines 20761 20931 +170 ========================================== + Hits 16895 17066 +171 + Misses 3866 3865 -1 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `81.53% <94.73%> (+0.15%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/NREL/reV/pull/410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL) | Coverage Δ | | |---|---|---| | [reV/bespoke/cli\_bespoke.py](https://app.codecov.io/gh/NREL/reV/pull/410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL2Jlc3Bva2UvY2xpX2Jlc3Bva2UucHk=) | `29.65% <25.00%> (-0.08%)` | :arrow_down: | | [reV/config/bespoke.py](https://app.codecov.io/gh/NREL/reV/pull/410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL2NvbmZpZy9iZXNwb2tlLnB5) | `62.85% <66.66%> (+0.11%)` | :arrow_up: | | [reV/bespoke/place\_turbines.py](https://app.codecov.io/gh/NREL/reV/pull/410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL2Jlc3Bva2UvcGxhY2VfdHVyYmluZXMucHk=) | `96.06% <94.11%> (-0.39%)` | :arrow_down: | | [reV/bespoke/bespoke.py](https://app.codecov.io/gh/NREL/reV/pull/410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL2Jlc3Bva2UvYmVzcG9rZS5weQ==) | `92.32% <96.46%> (+0.92%)` | :arrow_up: | | [reV/handlers/collection.py](https://app.codecov.io/gh/NREL/reV/pull/410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL2hhbmRsZXJzL2NvbGxlY3Rpb24ucHk=) | `80.96% <100.00%> (+0.90%)` | :arrow_up: | | [reV/supply\_curve/supply\_curve.py](https://app.codecov.io/gh/NREL/reV/pull/410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL3N1cHBseV9jdXJ2ZS9zdXBwbHlfY3VydmUucHk=) | `91.50% <100.00%> (ø)` | | | [reV/version.py](https://app.codecov.io/gh/NREL/reV/pull/410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL3ZlcnNpb24ucHk=) | `100.00% <100.00%> (ø)` | | | [tests/test\_bespoke.py](https://app.codecov.io/gh/NREL/reV/pull/410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-dGVzdHMvdGVzdF9iZXNwb2tlLnB5) | `100.00% <100.00%> (ø)` | | | [tests/test\_handlers\_collection.py](https://app.codecov.io/gh/NREL/reV/pull/410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-dGVzdHMvdGVzdF9oYW5kbGVyc19jb2xsZWN0aW9uLnB5) | `92.12% <100.00%> (+0.67%)` | :arrow_up: | ... and [11 files with indirect coverage changes](https://app.codecov.io/gh/NREL/reV/pull/410/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL):umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
ppinchuk
Mostly a collection of improvements to address annoyances I ran into while running bespoke for ATB turbines.
Also added the option to pre-load resource data before running bespoke for all sites. I've gotten mixed results with this feature so far. Initial testing seemed very promising, but more recent tests paint a less definitive picture of improvement. In any case, the code has already been implemented, and it may not be a bad thing to leave it as a toggleable option for the user.
This is Part 1 of my planned improvements for bespoke - mostly focused on quality-of-life adjustments. I will be adding a few logic-focused features in Part 2, but no ETA for that yet.