search

NREL / reV

Renewable Energy Potential (reV) Model
https://nrel.github.io/reV/
BSD 3-Clause "New" or "Revised" License
107 stars 24 forks source link

Solar AC capacity outputs #416

Closed ppinchuk closed 1 year ago

ppinchuk commented 1 year ago

Add option to outputs AC capacity and capacity factor for solar. Also allow transmission to be sized on a column other than "capacity" (e.g. "capacity_ac").

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 88.02% and project coverage change: +0.07 :tada:

Comparison is base (0c96891) 81.49% compared to head (39c342d) 81.56%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #416 +/- ## ========================================== + Coverage 81.49% 81.56% +0.07% ========================================== Files 144 144 Lines 20919 21053 +134 ========================================== + Hits 17048 17172 +124 - Misses 3871 3881 +10 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `81.56% <88.02%> (+0.07%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/NREL/reV/pull/416?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL) | Coverage Δ | | |---|---|---| | [reV/supply\_curve/cli\_supply\_curve.py](https://app.codecov.io/gh/NREL/reV/pull/416?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL3N1cHBseV9jdXJ2ZS9jbGlfc3VwcGx5X2N1cnZlLnB5) | `30.28% <25.00%> (-0.11%)` | :arrow_down: | | [reV/config/supply\_curve\_configs.py](https://app.codecov.io/gh/NREL/reV/pull/416?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL2NvbmZpZy9zdXBwbHlfY3VydmVfY29uZmlncy5weQ==) | `69.47% <50.00%> (-0.42%)` | :arrow_down: | | [reV/supply\_curve/points.py](https://app.codecov.io/gh/NREL/reV/pull/416?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL3N1cHBseV9jdXJ2ZS9wb2ludHMucHk=) | `87.84% <67.56%> (-1.17%)` | :arrow_down: | | [reV/SAM/generation.py](https://app.codecov.io/gh/NREL/reV/pull/416?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL1NBTS9nZW5lcmF0aW9uLnB5) | `92.00% <100.00%> (+0.08%)` | :arrow_up: | | [reV/supply\_curve/supply\_curve.py](https://app.codecov.io/gh/NREL/reV/pull/416?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL3N1cHBseV9jdXJ2ZS9zdXBwbHlfY3VydmUucHk=) | `91.95% <100.00%> (+0.45%)` | :arrow_up: | | [tests/test\_gen\_pv.py](https://app.codecov.io/gh/NREL/reV/pull/416?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-dGVzdHMvdGVzdF9nZW5fcHYucHk=) | `95.51% <100.00%> (+0.63%)` | :arrow_up: | | [tests/test\_supply\_curve\_compute.py](https://app.codecov.io/gh/NREL/reV/pull/416?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-dGVzdHMvdGVzdF9zdXBwbHlfY3VydmVfY29tcHV0ZS5weQ==) | `98.18% <100.00%> (+0.22%)` | :arrow_up: | | [tests/test\_supply\_curve\_sc\_aggregation.py](https://app.codecov.io/gh/NREL/reV/pull/416?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-dGVzdHMvdGVzdF9zdXBwbHlfY3VydmVfc2NfYWdncmVnYXRpb24ucHk=) | `94.47% <100.00%> (+0.35%)` | :arrow_up: | ... and [11 files with indirect coverage changes](https://app.codecov.io/gh/NREL/reV/pull/416/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

ppinchuk commented 1 year ago

Yea I looked through the rep-profiles code but I think all it uses are the GID values from the supply curve. We should be able to just change the cf_dset inputs, and that's exactly what I am doing right now for the solar standard scenario runs. Things seem to be working so far, but I can wait to merge this until I confirm that those outputs look good.

grantbuster commented 1 year ago

Yea I looked through the rep-profiles code but I think all it uses are the GID values from the supply curve. We should be able to just change the cf_dset inputs, and that's exactly what I am doing right now for the solar standard scenario runs. Things seem to be working so far, but I can wait to merge this until I confirm that those outputs look good.

Excellent!

ppinchuk commented 1 year ago

Rep profiles look good as far as I can tell. Merging this now but can revisit if anything else does come up