search

NREL / reV

Renewable Energy Potential (reV) Model
https://nrel.github.io/reV/
BSD 3-Clause "New" or "Revised" License
107 stars 24 forks source link

Fix out path bug #420

Closed ppinchuk closed 1 year ago

ppinchuk commented 1 year ago

Previous version of code would add a year value to the module name everywhere in the path. For example, a generation run for year 2012 in the directory /my/path/to/generation/runs would give an output file in /my/path/to/generation_2012/run/generation_2012.h5. New version of code only performs this substitution in the file name.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 81.57% and project coverage change: +0.05% :tada:

Comparison is base (497bb7d) 86.87% compared to head (1a573e8) 86.92%. Report is 25 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #420 +/- ## ========================================== + Coverage 86.87% 86.92% +0.05% ========================================== Files 122 122 Lines 16810 16837 +27 ========================================== + Hits 14603 14635 +32 + Misses 2207 2202 -5 ``` | [Flag](https://app.codecov.io/gh/NREL/reV/pull/420/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/NREL/reV/pull/420/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL) | `86.92% <81.57%> (+0.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/NREL/reV/pull/420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL) | Coverage Δ | | |---|---|---| | [reV/qa\_qc/qa\_qc.py](https://app.codecov.io/gh/NREL/reV/pull/420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL3FhX3FjL3FhX3FjLnB5) | `30.05% <0.00%> (ø)` | | | [reV/qa\_qc/summary.py](https://app.codecov.io/gh/NREL/reV/pull/420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL3FhX3FjL3N1bW1hcnkucHk=) | `45.34% <0.00%> (ø)` | | | [reV/rep\_profiles/cli\_rep\_profiles.py](https://app.codecov.io/gh/NREL/reV/pull/420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL3JlcF9wcm9maWxlcy9jbGlfcmVwX3Byb2ZpbGVzLnB5) | `29.41% <0.00%> (-0.59%)` | :arrow_down: | | [tests/test\_supply\_curve\_sc\_aggregation.py](https://app.codecov.io/gh/NREL/reV/pull/420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-dGVzdHMvdGVzdF9zdXBwbHlfY3VydmVfc2NfYWdncmVnYXRpb24ucHk=) | `94.71% <ø> (ø)` | | | [reV/generation/base.py](https://app.codecov.io/gh/NREL/reV/pull/420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL2dlbmVyYXRpb24vYmFzZS5weQ==) | `83.63% <81.81%> (ø)` | | | [reV/supply\_curve/sc\_aggregation.py](https://app.codecov.io/gh/NREL/reV/pull/420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL3N1cHBseV9jdXJ2ZS9zY19hZ2dyZWdhdGlvbi5weQ==) | `81.87% <100.00%> (+0.28%)` | :arrow_up: | | [reV/supply\_curve/supply\_curve.py](https://app.codecov.io/gh/NREL/reV/pull/420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL3N1cHBseV9jdXJ2ZS9zdXBwbHlfY3VydmUucHk=) | `92.06% <100.00%> (+0.09%)` | :arrow_up: | | [reV/version.py](https://app.codecov.io/gh/NREL/reV/pull/420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL3ZlcnNpb24ucHk=) | `100.00% <100.00%> (ø)` | | | [tests/test\_gen\_config.py](https://app.codecov.io/gh/NREL/reV/pull/420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-dGVzdHMvdGVzdF9nZW5fY29uZmlnLnB5) | `95.53% <100.00%> (+0.12%)` | :arrow_up: | ... and [13 files with indirect coverage changes](https://app.codecov.io/gh/NREL/reV/pull/420/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.