search

NREL / reV

Renewable Energy Potential (reV) Model
https://nrel.github.io/reV/
BSD 3-Clause "New" or "Revised" License
107 stars 24 forks source link

Gb/bc #439

Closed grantbuster closed 10 months ago

grantbuster commented 10 months ago

Primarily motivated by Sup3rCC, we need to be able to use more complex bias correction methods so this PR opens up some flexibility in using any functions we implement in rex.

ppinchuk commented 10 months ago

Looks like we should handle the rex PR first, publish it to PyPi, then bump the req here for the tests?

grantbuster commented 10 months ago

Looks like we should handle the rex PR first, publish it to PyPi, then bump the req here for the tests?

Yes. Huh i thought for reV tests we cloned the rex repo but i guess we will have to do a pypi release for rex.

codecov-commenter commented 10 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (7689ae8) 87.04% compared to head (934b71e) 87.11%.

Files Patch % Lines
reV/bespoke/bespoke.py 90.62% 3 Missing :warning:
reV/generation/generation.py 91.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #439 +/- ## ========================================== + Coverage 87.04% 87.11% +0.07% ========================================== Files 122 122 Lines 17107 17163 +56 ========================================== + Hits 14891 14952 +61 + Misses 2216 2211 -5 ``` | [Flag](https://app.codecov.io/gh/NREL/reV/pull/439/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/NREL/reV/pull/439/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL) | `87.11% <95.74%> (+0.07%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.