NREL / reV

Renewable Energy Potential (reV) Model
https://nrel.github.io/reV/
BSD 3-Clause "New" or "Revised" License
107 stars 24 forks source link

reV Geothermal EGS design temp fix #445

Closed ppinchuk closed 9 months ago

ppinchuk commented 9 months ago

Allow user to set the EGS plant design temperature to match the resource temperature just like the SAM GUI does.

We received confirmation form the SAM team that there are no plans to expose their toggleable option in PySAM, so we had to go for this workaround.

codecov-commenter commented 9 months ago

Codecov Report

Attention: Patch coverage is 98.49246% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 87.17%. Comparing base (b9a2c8d) to head (1fbd11b).

Files Patch % Lines
tests/test_gen_geothermal.py 98.37% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #445 +/- ## ========================================== + Coverage 87.12% 87.17% +0.05% ========================================== Files 122 122 Lines 17212 17246 +34 ========================================== + Hits 14996 15035 +39 + Misses 2216 2211 -5 ``` | [Flag](https://app.codecov.io/gh/NREL/reV/pull/445/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/NREL/reV/pull/445/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL) | `87.17% <98.49%> (+0.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.