Open ekpresent opened 1 year ago
Sounds like it is a TSV logic. Might need to add a dependency related to Shared Systems, Ducts, and Heating Type.
Team to check LARGEEE run buildstocks to confirm this didn't change for RECS 2020 data update.
@ekpresent : To update table with cooling system
See highligted section below: ducted heating, no cooling, but system type is baseboard heaters. I think we got here in logical fashion but the result looks weird (This is from EUSS RR1).
Related to restock-estimation Issue: https://github.com/NREL/resstock-estimation/issues/254
Per recent PR #1104 and #1112, some of these inconsistencies have been resolved (i.e., HVAC Has Shared Systems, HVAC Has Ducts, HVAC Heating Efficiency, HVAC Cooling Efficiency, and HVAC Shared Efficiencies are consistent). Here is the latest joint combinations.
Currently none of the shared systems are ducted, hence HVAC has ducts is being restricted to ductless for them (e.g., HVAC Has Shared Systems = "Heating and Cooling" can only be paired with HVAC Has Ducts ="No"), but notice HVAC Heating Type (and Fuel by extension I think) and HVAC Cooling Type are still somewhat inconsistent due to them lacking equivalent field(s) for shared systems (e.g., Fan Coil Cooling is not Central AC, shared baseboards are not ducted heating). Updating those were not the priorities in the recent PRs as they are tags and not associated with ResStockArguments. Before we want to fix them, the followup question is, do we want to model ducted shared systems?
@ekpresent @afontani
This is from EUSS RR1 but I suspect it hasn't changed - should we change the ducting to match the shared efficiencies type?