MNT: Do not resolve configuration at import time.

NSLS-II / metadatastore

DEPRECATED: Incorporated into https://github.com/NSLS-II/databroker

Other

2 stars 11 forks source link

MNT: Do not resolve configuration at import time. #231

Closed danielballan closed 8 years ago

danielballan commented 8 years ago

This is what I had in mind. A conf dict with Nones silently filled in (https://github.com/NSLS-II/metadatastore/pull/230) seems more potentially confusing than a KeyError on importing metadatastore.conf.

Would this change, which is analogous to how FS works, provide what metadataservice needs?

codecov-io commented 8 years ago

Current coverage is 86.80%

Merging #231 into master will decrease coverage by <.01%

@@             master       #231   diff @@
==========================================
  Files             7          7          
  Lines           872        871     -1   
  Methods           0          0          
  Messages          0          0          
  Branches        146        146          
==========================================
- Hits            757        756     -1   
  Misses           85         85          
  Partials         30         30

Powered by Codecov. Last updated by 3826b71...c181586

ghost commented 8 years ago

Yes, it provides what mdservice needs