Authenticate mongoserv

[codecov-io]

Current coverage is 89.57% (diff: 77.77%)

Merging #248 into master will decrease coverage by 1.18%

@@             master       #248   diff @@
==========================================
  Files             6          4     -2   
  Lines           552        470    -82   
  Methods           0          0          
  Messages          0          0          
  Branches         88         75    -13   
==========================================
- Hits            501        421    -80   
  Misses           34         34          
+ Partials         17         15     -2   

Powered by Codecov. Last update 485db65...9cd05d2

[tacaswell]

Coverage went down because we removed covered lines of code, but did not create any new misses.

[tacaswell]

Can you also add a note in the api_changes folder?

Something like

API: remove mds.commands & mds.api + add auth

• Remove the singleton based API to metadatastore, use MDS / MDSRO instances instead
• require auth when connecting to mongo by default

[ghost]

@tacaswell Good to go

[tacaswell]

@arkilic Can you please fix the bluesky (and I think ophyd) tests that will be broken by these api changes and update https://nsls-ii.github.io/fresh-installation.html with directions on how to set up authentication on the mongo server?

Why do we need an auth flag? It would be simpler to just check if a username/password are included in the config?

[ghost]

Will do, I just need a day long detox from travis.

The flag is to be able to efficiently toggle between authenticated and open shells. I don't like the idea of just checking for username/pwd since someone can easily forget to populate these fields even when they're required.

[ghost]

@tacaswell This means we don't need to fix the databroker tests?

[tacaswell]

Did you link to the wrong thing? That was my attempt to pre-emptively fix the bluesky tests.

[ghost]

Nope, the link is fine. Talked to @danielballan offline yesterday, the confusion is resolved.