Closed tacaswell closed 7 years ago
Coverage went down because we removed covered lines of code, but did not create any new misses.
Can you also add a note in the api_changes folder?
Something like
API: remove mds.commands & mds.api + add auth
@tacaswell Good to go
@arkilic Can you please fix the bluesky (and I think ophyd) tests that will be broken by these api changes and update https://nsls-ii.github.io/fresh-installation.html with directions on how to set up authentication on the mongo server?
Why do we need an auth flag? It would be simpler to just check if a username/password are included in the config?
Will do, I just need a day long detox from travis.
The flag is to be able to efficiently toggle between authenticated and open shells. I don't like the idea of just checking for username/pwd since someone can easily forget to populate these fields even when they're required.
Did you link to the wrong thing? That was my attempt to pre-emptively fix the bluesky tests.
Nope, the link is fine. Talked to @danielballan offline yesterday, the confusion is resolved.
Current coverage is 89.57% (diff: 77.77%)