search

NSLS-II / wishlist

an issue tracker for the big picture
1 stars 0 forks source link

Add support for reciprocal space #81

Closed stuwilkins closed 8 years ago

stuwilkins commented 8 years ago

At CSX we need support for both driving the diffractometer in reciprocal space coordinates (HKL, QxQyQz) scanning etc.

Integration with the metadata is needed for the UB matrix.

Support to reconstruct using Q space routines and grinding is also needed.

Attn @ambarbm @cmazzoli.

This should also apply to CXH and ISR and possibly SMI

This is needed for the next run at NSLS-II

tacaswell commented 8 years ago

define 'next run'

stuwilkins commented 8 years ago

The 2016-1 run, starting mid Jan 2016

tacaswell commented 8 years ago

Great, the bold text made me think you meant next week.

klauer commented 8 years ago

@tacaswell recently pushed through some pending gobject-introspection changes which were holding up progress for getting this going in the new Python 3 data collection environments.

I'll try update my old hkl branch in my spare time soon (what else is spare time for but more work, after all?). Barring any other major library-related issues, it should be possible to get things going for the next run.

Will you have time to play around with hkl stuff during the shutdown @stuwilkins? Is any of our team aware of your detailed requirements (i.e., anything beyond what you have outlined here)?

heroux commented 8 years ago

Stuart, in order to have a good user experience, I suggest to not schedule any users requiring this scan until we have a better idea when this can be delivered and tested. It turns out that we do have a fair amount of work to get done for other beamlines too.

stuwilkins commented 8 years ago

Hi @klauer yes I can test. @heroux if your comment is true then I will have to cancel all users at CSX next cycle. If you would like me to do this then I can but CSX-1 will run no users ...... This was originally promised but the DAMA group for the 2015-3 run but never made it causing us problems. We can run in 2016-1 without it.

Attn @cmazzoli, @ambarb

heroux commented 8 years ago

Stuart, there is obviously work being done by several people in this group on this subject. Again, I don't have a view on your scheduled users. You know best about what your beamline can do and what the users want to do. It's up to you to balance that in order for them to have a successful experience here.

We need to have time to develop the code and TEST it AND have the other beamlines be able to have users. In order to be more transparent on what the group is working on and the priorities, we will try to provide an estimate on how much time is needed to implement items on the wishlist.

Annie

+++++++++++++++++++++++++++ Energy Sciences Directorate/Photon Science Division, Bldg 745 L107 Brookhaven National Laboratory Upton, NY 11973, USA Phone office: 631 344 4454

From: Stuart Wilkins [notifications@github.com] Sent: Wednesday, November 04, 2015 8:34 AM To: NSLS-II/wishlist Cc: Heroux, Annie Subject: Re: [wishlist] Add support for reciprocal space (#81)

Hi @klauerhttps://github.com/klauer yes I can test. @herouxhttps://github.com/heroux if your comment is true then I will have to cancel all users at CSX next cycle. If you would like me to do this then I can but CSX-1 will run no users ......

Attn @cmazzolihttps://github.com/cmazzoli, @ambarbhttps://github.com/ambarb

— Reply to this email directly or view it on GitHubhttps://github.com/NSLS-II/wishlist/issues/81#issuecomment-153720288.

stuwilkins commented 8 years ago

@heroux, I am afraid I don't agree. Having this type of base support for reciprocal space has been a requirement for CSX for ages. It is not as simple as scheduling different users... all users need this functionality as we do physics which uses reciprocal space. Everything from the beamline side is ready - we are just waiting on the reciprocal space routines.

I fully understand - as you know - the need to develop and TEST code as you see. You will also see that I offered @klauer both myself and the beamline staff to help in that testing and development and we have built.

If you want to discuss this ... my door is always open. I would be happy to share both the beamline calendar and our requirements. I will be back tomorrow (Thursday) Please ask Jean to book some time. Thanks.

stuwilkins commented 8 years ago

Linking to issue #12 which was added back in July showing the requirement.

tacaswell commented 8 years ago

Closing as a duplicate of #12