search

NSWSESMembers / availability-poc

WIP proof of concept availability app
MIT License
10 stars 4 forks source link

Server - Map redraw bug #511

Closed OSPFNeighbour closed 6 years ago

OSPFNeighbour commented 6 years ago

was causing the map to reset and rezoom because it was removing the map for a split second.

codecov[bot] commented 6 years ago

Codecov Report

Merging #511 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #511   +/-   ##
======================================
  Coverage    28.2%   28.2%           
======================================
  Files         172     172           
  Lines        2801    2801           
  Branches      412     412           
======================================
  Hits          790     790           
  Misses       1700    1700           
  Partials      311     311
Flag Coverage Δ
#integration 0% <ø> (ø) :arrow_up:
#unittests 28.74% <0%> (ø) :arrow_up:
Impacted Files Coverage Δ
client/src/screens/events/Detail.js 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 05b7380...9d9a7d7. Read the comment docs.

OSPFNeighbour commented 6 years ago

Yeah its both, This causes the token manager to want to redraw for some weird reason (which we settled down with a shouldComponentUpdate), which causes this to draw and you get a mad loop.