NTD-Modelling-Consortium / ntd-model-sch

NTD SCH model
MIT License
0 stars 6 forks source link

get_venv test failing on CI #39

Closed thk123 closed 3 months ago

thk123 commented 3 months ago

On the unmerged #36 - the tests for get_venv when it should not find a virtual environment are currently failing, for now disabling on CI but should investigate and fix.

thk123 commented 3 months ago

This fails locally too so disabling the test for now. The problem is caused by the test that calls python code seems to be activating the virtual env which means get_venv always finds the virtual env of the project.

thk123 commented 3 months ago

Ended up not even needing this function as reticulate implements this behaviour anyway .