search

NTD-Modelling-Consortium / ntd-model-sch

NTD SCH model
MIT License
0 stars 6 forks source link

Add a github-actions workflow to run `ruff` #56

Closed tlestang closed 3 months ago

tlestang commented 3 months ago

Runs like the tests, whenever new commits are pushed to a PR branch or when pushed to master.

tlestang commented 3 months ago

Thanks for reviewing

Put instructions in the failed CI job for how to fix the formatting errors and push again. People might not know how to use the tool.

I added contributing guidelines including how to use ruff format in the readme, just in a previous PR that was merged (#49).

Maybe the ruff jobs should run first and fail fast (though this could of course be done later because all of the jobs are pretty small at this point)

That's a good idea! I'll merge the lint workflow into the test one and condition the start of the tests on the lint job