search

NVIDIA-Merlin / core

Core Utilities for NVIDIA Merlin
Apache License 2.0
19 stars 14 forks source link

Merge `release-23.04` into `main` #304

Closed karlhigley closed 1 year ago

karlhigley commented 1 year ago

This is important to do after our releases so that the latest release tag can be found somewhere in the history of our main branch. Without that, Versioneer reports its version as the latest version tag it can find on the main branch (which is currently v0.9.0), and that causes version conflicts in our Github Actions when tox test runs install from main. The problem surfaced now because we updated dependency specifiers between Merlin libraries as part of the 23.04 release, which we hadn't been doing regularly and let us get away with not doing this.

oliverholworthy commented 1 year ago

If we're happy with the dev tags approach described here. https://github.com/NVIDIA-Merlin/Merlin/issues/961 Then I think this PR can be closed. Applying the dev tags achieves the goal that this merge of the release branch was aiming for which is for versioneer to return a version that correctly reflects the state of the branch.