NVIDIA / NeMo

A scalable generative AI framework built for researchers and developers working on Large Language Models, Multimodal, and Speech AI (Automatic Speech Recognition and Text-to-Speech)
https://docs.nvidia.com/nemo-framework/user-guide/latest/overview.html
Apache License 2.0
12.3k stars 2.55k forks source link

Enable packed dataset for validation; add a2a_experimental argument #11378

Closed michal2409 closed 6 days ago

michal2409 commented 1 week ago

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

Usage

# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

PR Type:

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed. Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

github-actions[bot] commented 1 week ago

beep boop šŸ¤–: šŸ™ The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.


Your code was analyzed with PyLint. The following annotations have been identified:

************* Module nemo.collections.llm.gpt.data.packed_sequence
nemo/collections/llm/gpt/data/packed_sequence.py:94:0: C0301: Line too long (123/119) (line-too-long)
nemo/collections/llm/gpt/data/packed_sequence.py:89:0: C0115: Missing class docstring (missing-class-docstring)
************* Module nemo.collections.llm.peft.lora
nemo/collections/llm/peft/lora.py:50:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/llm/peft/lora.py:56:0: C0115: Missing class docstring (missing-class-docstring)
nemo/collections/llm/peft/lora.py:87:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/llm/peft/lora.py:99:0: C0116: Missing function or method docstring (missing-function-docstring)

-----------------------------------
Your code has been rated at 9.76/10

Thank you for improving NeMo's documentation!

github-actions[bot] commented 6 days ago

[šŸ¤–]: Hi @michal2409 šŸ‘‹,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g