search

NVIDIA / container-canary

A tool for testing and validating container requirements against versioned manifests
Apache License 2.0
246 stars 15 forks source link

Add --log-file argument and log test result details #54

Open KyleFromNVIDIA opened 9 months ago

KyleFromNVIDIA commented 9 months ago

Add a --log-file argument for container-canary to write detailed logs, so that developers can see exactly how and why a test failed.

jameslamb commented 6 months ago

I'd like to revive this, but I don't have write access here.

@KyleFromNVIDIA could you update this to latest main and add a PR description?

And @jacobtomlinson after that could you help us out with a review?

jacobtomlinson commented 6 months ago

@jameslamb I've added you to the codeowners team here. @KyleFromNVIDIA I was unable to add you as you're not a member of the @nvidia org, we probably need to figure out how to add you so that you can be added to the codeowners.

KyleFromNVIDIA commented 6 months ago

I was unable to add you as you're not a member of the @NVIDIA org, we probably need to figure out how to add you so that you can be added to the codeowners.

I've fixed this, you can go ahead and add me.

KyleFromNVIDIA commented 5 months ago

@jameslamb @jacobtomlinson Is there anything else left to address here?