NVIDIA / warp

A Python framework for high performance GPU simulation and graphics
https://nvidia.github.io/warp/
Other
4.3k stars 246 forks source link

[REQUEST] Add atomic_max and atomic_min for float64 #284

Closed swan2818 closed 1 month ago

swan2818 commented 4 months ago

Description

For now, the atomic_max and atomic_min operators in Warp are for float and int only.

Context

Please support float64 for the atomic_max and atomic_min operators.

Irene-123 commented 3 months ago

Hi @swan2818 @shi-eric I went through this issue and looking to contribute here I was hoping if this is an priority task and I could take it up as my good-first-issue? Lmk if there's something else I can work upon, thanks!

shi-eric commented 3 months ago

Hi @Irene-123, thanks for volunteering! I think @daedalus5 might already be working on this issue. The other two you expressed an interest in should be open for you to take up.

Irene-123 commented 3 months ago

That's great, thank you @shi-eric Is there a discord channel to have a discussion?

shi-eric commented 3 months ago

That's great, thank you @shi-eric Is there a discord channel to have a discussion?

Yes, there is a channel for Warp in the Omniverse Discord server (link)

daedalus5 commented 3 months ago

Yes I have an MR in for this now.