NYCPlanning / data-engineering

Primary repository for NYC DCP's Data Engineering team
14 stars 0 forks source link

"Odd lots" - ZTL QA follow-up #921

Open jackrosacker opened 1 week ago

jackrosacker commented 1 week ago

ZTL QA is finished, and has passed, but I'm flagging two lots that appeared in the qc_bbldiff file that should plausibly have been caught by an earlier build.

BBL Image
3075760012 image
4089250001 image

Note that both seem to be improvements, but since they are correcting on errors that appear to have persisted in previous versions without being picked up by either the ZTL build or the QA process, flagging for further review.

bblnew zd1new zd2new zd1prev zd2prev
3075760012 R6   R6 C8-2
4089250001 R6A R3-1 R6A  
fvankrieken commented 1 week ago

Can you clarify what you mean by "caught"? What was the issue with these lots?

jackrosacker commented 1 week ago

For both, the extent of the zoning files didn't change, but the zoning values on the lots did. The second lot at least intersects with both relevant zoning districts, while the first doesn't intersect at all with the old zd2 district.

In the image, the pink indicates the qc bbldiff lot. The orange lines/labels indicate the current nyzd file, and the green lines/labels indicate the prior nyzd file.

I'll add a snippet of the attribute table to the initial comment.

fvankrieken commented 1 week ago

Gotcha.

At least with the first, looks like a real change? Looking at zola, it's clearly partially in a C8-2

image

Based on your screenshot, looks like the lot was split.

The second looks a little more odd

jackrosacker commented 1 week ago

According to the DTMs we have archived, it looks like the first lot split between the 3/29 and 4/5 versions, while this current QA should be comparing between the DTM from the current build (6/4) and the DTM from the prior build (5/3).

It looks like an error is being corrected, but it's odd that it's popping up now and not earlier in the Spring.