fix `dof_dtm` failing to archive

[damonmcc]

related issues/PRS

• https://github.com/nycplanning/db-zoningtaxlots/issues/130
• https://github.com/NYCPlanning/db-zoningtaxlots/pull/132

notes

• failure to archive dof_dtm slowed down ZTLDB and Pluto builds
• during investigation and temporary fixes, didn't find root cause
• findings that may be relevant
  • archiving "succeeds" but output file is half the size it should be (162.3 MB instead of 353.8 MB)
  • 20220603 is the last version in edm-publishing that is succeeding at the moment
  • 20230203 is the last version in edm-recipes that has the expected file size
  • archiving seems to fail at gdal.VectorTranslate in ingest.py, but error doesn't give details
• suspected root cause(s)
  • multiple geometry types in source shapefile (rather than only MULTIPOLYGON)
  • invalid geometries in source shapefile

[damonmcc]

Amanda fixed by opening in ArcMap, seeing an error message about null/invalid geometries, and clicking a "fix geometries" option

[damonmcc]

Amanda fixed by opening in ArcMap, seeing an error message about null/invalid geometries, and clicking a "fix geometries" option. ArcMap output attached

DTM_20230323_CheckGeometry_Output.txt

[damonmcc]

per convos with @NYCPlanning/gis team and their ongoing work in new issue https://github.com/NYCPlanning/edm-overview/issues/891

• seems to be caused by self-intersecting geometries
• they'll use ESRI's "fix geometries" via ArcPro and/or scripts to fix the dtm before uploading to edm-publishing