search

NYCPlanning / db-equitable-development-tool

Data Repo for the equitable development tool (EDDT)
MIT License
0 stars 0 forks source link

Add in percent fields for units_payingrent in Housing Security #269

Closed AmandaDoyle closed 2 years ago

AmandaDoyle commented 2 years ago

Add in percent fields for units_payingrent in Housing Security

SashaWeinstein commented 2 years ago

The pct and pct moe fields in the source data are always null for "HUPRt"

AmandaDoyle commented 2 years ago

Okay - let me look into this before we address

AmandaDoyle commented 2 years ago

Initial goal: Add the percent and percent moe value for the base variable for the units affordable by ami variables. Discovery: These data points are already in the output, but the field name is incorrect because the label in the source data is incorrect. In the source data for units affordable by ami, the base variable provided is Renter-occupied units aka ROcc2_19. We map ROcc2 to units_renteroccu, which is included in the output with the percent and percent moe fields. Though, the label in the source data should be HUPRt and the data should be mapped to units_payingrent. 'units_payingrentalready exists in the source data asunits_payingrent_0812' and units_payingrent_1519. units_payingrent from the AMI data is units_payingrent_1519. Devise a simple way rename and/or consolidate the base variable for the units AMI set of data.

td928 commented 2 years ago

Okay I worked on both of these so I am assigning myself to this.

SashaWeinstein commented 2 years ago

Ok great thanks Te I am very confused haha

td928 commented 2 years ago

Hey @AmandaDoyle  before I am heading down a completely wrong path here. I am adding in the pct and pct_moe for  HUPRt but they are all null in the source data. Just making sure this is expected. EDDT_ACS2008-2012.xlsx

AmandaDoyle commented 2 years ago

These fields are not null in the source data for units affordable by ami. The pct field always has a value of 100 and the pct moe field is null.

td928 commented 2 years ago

okay then I am a little confused if we are going with the units affordable source file then we will only have one year (2019) and pct is always 100. Also I just noticed the ami source file won't have race breakdown.

AmandaDoyle commented 2 years ago

That's right that there will only be pct and pct moe for 1519 data, and yes there is no race breakdown.

td928 commented 2 years ago

That's right that there will only be pct and pct moe for 1519 data, and yes there is no race breakdown.

okay so 0812 would have race breakdown and null pct and pct_moe and 1519 would be what you said? @AmandaDoyle

AmandaDoyle commented 2 years ago

@td928 I recognize that this isn't the cleanest. We need to get something to OSE asap. Goal: Add in percent and percent moe field for units_payrent_1519 - data comes from units affordable to ami. It doesn't matter if we add in percent and percent moe field for units_payrent_1519 by subgroup or units_payrent_0812 fields, as there is no data or use case for these fields. Given that we know that units_payrent_1519_pct is 100 for all values we could do a hotfix and hardcode it in until we develop a more elegant solution. percent moe field is null.

td928 commented 2 years ago

Okay great I think I was thinking along the same line then with hard coding that one column and then leave the rest. I will have a PR for this soon. Thank you!