Closed mbh329 closed 2 years ago
Things to note: did not add accessor to list @SashaWeinstein check column name is correct @AmandaDoyle
Just starting to look at this now and noticing that the tests broke because
from matplotlib.pyplot import get
was accidentally added to income_restricted_units.py
. I was running into this issue too and turned off my auto-imports which kept it from happening. This blog post was helpful https://github.com/microsoft/pylance-release/issues/64
@SashaWeinstein the os
and numpy
imports are also autoimports I believe? Will they break the tests as well? Ill take a look at that documentation because I know this has happened before
os and numpy shouldn't break the tests, it's usually matplotlib that breaks them
@AmandaDoyle got it
@SashaWeinstein see new commit for requested changes
income_restricted_units.py
This indicator was originally using one source data for two separate data points according to our original data matrix. However, we learned that these data points weren't capturing what the SME's were looking for so this pull request addresses the issues as stated in #267 and #265.
265
We needed to change the source data as the old data point
units_rad
was not what the SME's wanted, they were looking for the number of total units coming from the housing new york data. In the script, I loaded in this data and cleaned the data with established conventions and added a new helper function that converts NTA's to PUMAs. I also created a separate accessor function to handle this one data point as it used different data from the original accessor.267
This was an easy fix and just pointed the
units_nycha
to a the proper column as mentioned in this issue.CD_helpers.py
Added more descriptive name for the get crosswalk, renamed all the columns in the xlsx sheet and then created a new function to go from nta to puma.