ami-tools install issue: setup.py deprecation

bturkus commented 10 months ago

hi, i'm not sure if this is due to my new computer setup, but I'm experiencing an install issue with ami-tools. My read on this is that setup.py is deprecated as of python 3.12.

running pip3 install --user 'ami-tools @ git+https://github.com/NYPL/ami-tools', i'm getting the following error:

Installing collected packages: argparse, ami-tools
  DEPRECATION: ami-tools is being installed using the legacy 'setup.py install' method, because it does not have a 'pyproject.toml' and the 'wheel' package is not installed. pip 23.1 will enforce this behaviour change. A possible replacement is to enable the '--use-pep517' option. Discussion can be found at https://github.com/pypa/pip/issues/8559
  Running setup.py install for ami-tools ... error
  error: subprocess-exited-with-error

  × Running setup.py install for ami-tools did not run successfully.
  │ exit code: 1
  ╰─> [4 lines of output]
      running install
      /Users/benjaminturkus/.pyenv/versions/3.12.0a7/lib/python3.12/site-packages/setuptools/command/install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
        warnings.warn(
      error: [Errno 17] File exists: '/Users/benjaminturkus/.pyenv/versions/3.12.0a7/bin/python3.12'
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: legacy-install-failure

× Encountered error while trying to install package.
╰─> ami-tools

note: This is an issue with the package mentioned above, not pip.
hint: See above for output from the failure.

[notice] A new release of pip is available: 23.0.1 -> 23.3
[notice] To update, run: pip install --upgrade pip

bturkus commented 10 months ago

followed these steps to get it installed: 1) pip3 install --upgrade pip 2) pip3 install wheel 3) pip3 install --user --use-pep517 'ami-tools @ git+https://github.com/NYPL/ami-tools'

bturkus commented 10 months ago

sorry for the continuing messages. though this worked, I then began experiencing numpy and pandas compatibility issues (with 3.12). had to roll back to 3.10 with pyenv, but maybe the best bet would be to keep our eyes on 3.12 developments.

nkrabben commented 10 months ago

Makes sense.

I've put in a lot of work on figuring out the new packaging format, pyproject.toml, and learning the python version tester. should help with all of this, but i'll need time to switch the structure of this project over.

On Fri, Oct 20, 2023 at 3:12 PM bturkus @.***> wrote:

sorry for the continuing messages. though this worked, I then began experiencing numpy and pandas compatibility issues (with 3.12). had to roll back to 3.10 with pyenv, but maybe the best bet would be to keep our eyes on 3.12 developments.

— Reply to this email directly, view it on GitHub https://github.com/NYPL/ami-tools/issues/92#issuecomment-1773270492, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2XZP5M2RM7KLR5ORCR2DDYALEKZAVCNFSM6AAAAAA6JOH4KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZTGI3TANBZGI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

NYPL / ami-tools

ami-tools install issue: setup.py deprecation #92