DSD-1847: decorativeBookBroken icon - Githubissues

NYPL / nypl-design-system

React design system putting accessibility first.

https://nypl.github.io/nypl-design-system/reservoir/v3/?path=/docs/welcome--docs

Apache License 2.0

70 stars 6 forks source link

DSD-1847: decorativeBookBroken icon #1681

Closed bigfishdesign13 closed 1 month ago

bigfishdesign13 commented 1 month ago

Fixes JIRA ticket DSD-1847

This PR does the following:

Adds the "decorativeBookBroken" option (for error pages) to the Icon component.

How has this been tested?

local Storybook

Accessibility concerns or updates

n/a

Accessibility Checklist

[ ] Checked Storybook's "Accessibility" tab for color contrast and other issues.
[ ] The feature works with keyboard inputs including tabbing back and forward and pressing space, enter, arrow, and esc keys.
[ ] For hidden text or when aria-live is used, a screenreader was used to verify the text is read.
[ ] For features that involve UI updates and focusing on DOM refs, focus management was reviewed.
[ ] The feature works when the page is zoomed in to 200% and 400%.

Open Questions

-

Checklist:

[ ] I have updated the Storybook documentation and changelog accordingly.
[ ] I have added relevant accessibility documentation for this pull request.
[ ] All new and existing tests passed.

Front End Review:

[ ] Review the Vercel preview deployment once it is ready.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nypl-design-system	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 7, 2024 11:02pm