search

NZRS / wavetrace

Radio propagation modelling
GNU Affero General Public License v3.0
61 stars 22 forks source link

Code review ideas: internationalise the parameters #16

Open ghost opened 8 years ago

ghost commented 8 years ago

make_files.py;

print >> f, '''15.000 ; Earth Dielectric Constant (Relative permittivity) 0.005 ; Earth Conductivity (Siemens per meter) 301.000 ; Atmospheric Bending Constant (N-units) '''+ inner_dict['frequency_mhz'] + ''' ; Frequency in MHz (20 MHz to 20 GHz) 6 ; Maritime Temperate, over land (UK and west coasts of US & EU) ''' + pol + ''' ; Polarization (0 = Horizontal, 1 = Vertical) 0.5 ; Fraction of situations (50% of locations) 0.5 ; Fraction of time (50% of the time) ''' + inner_dict['power_eirp'] + ''' ; ERP in watts'''

These parameters could be internationalised into a dict, enabling other users to contribute back their dicts rather than just getting the code and localising the parameters

jamiesgithub commented 8 years ago

These parameters are not super localised. Its very macro. It would be great to have a way to define what they are, but there won't be others contributing back their own dicts....

7 Climate 4 Soli permittivity

http://www.softwright.com/faq/engineering/prop_longley_rice.html

Please make it happen though