Update create_output_from_dir.py

NZRS / wavetrace

Radio propagation modelling

GNU Affero General Public License v3.0

61 stars 22 forks source link

Update create_output_from_dir.py #9

Closed ghost closed 8 years ago

ghost commented 8 years ago

Fixes issue #2

No tests so far but works for me

seb-at-nzrs commented 8 years ago

We are going to do a full code review. I'll accept the pull request as we identified that as an easy fix, but the code in general can be improved.

ghost commented 8 years ago

Agreed: I'd rewrite kml2wld.sh as python - I spend half my life in shells, but if you can't expect too many contributors to do shell and python. By rewriting kml2wld in python your python contributors can debug line by line in their IDE. I had a quick look - nothing difficult in there and it would be/could be easier to read in python.

Can anyone be involved in the review?

jamiesgithub commented 8 years ago

kml2wld.sh is just begging to be rewritten.....