search

Naezr / ShyFox

A very shy little theme that hides the entire browser interface in the window border
Mozilla Public License 2.0
1.69k stars 31 forks source link

Update Readme - How to match ShyFox's accent color with icons' color #103

Closed Reyshyram closed 4 months ago

Reyshyram commented 4 months ago

Update the Readme to inform how to match ShyFox's accent color with Pywalfox's accent color

Naezr commented 4 months ago

Could you tell me what Pywalfox is?

A quick run through their README I didn't notice much difference with Firefox Color. Also, the Pywal repository that this thing seems to be based on is archived and read-only.

Also -toolbarbutton-icon-fill is just the color of the icon fill, as the name makes clear. It would be better to get away from any particular extension and leave a note on how to make the accent identical to the icon fill color. Or even add a setting in about:config that switches the accent from a manually specified color to the fill color of the icons. I'm also not sure if -toolbarbutton-icon-fill is available in userContent.css.

> [!NOTE]
> So there's a lot to think about here. I'd be glad to hear your explanations

[!NOTE] So there's a lot to think about here. I'd be glad to hear your explanations

Reyshyram commented 4 months ago

Pywalfox is different from Firefox Color in the fact that it relies on pywal (now pywal16, the updated version of pywal, the link on Pywalfox's readme hasn't be corrected).

Pywal takes the colors from your wallpaper and generates colorschemes that can be applied on the fly to your system.
You can create template for colorschemes to further customize your system.

For example:

So, changing to pywalfox's accent color would allow ShyFox to be better integrated with the rest of the system when using pywal.

Also -toolbarbutton-icon-fill is just the color of the icon fill, as the name makes clear. It would be better to get away from any particular extension and leave a note on how to make the accent identical to the icon fill color. Or even add a setting in about:config that switches the accent from a manually specified color to the fill color of the icons. I'm also not sure if -toolbarbutton-icon-fill is available in userContent.css.

How should I proceed to add a setting in about:config ?

Naezr commented 4 months ago

Okay, thanks, I got it. Actually, coloring the accent to the icon fill color will be useful in normal themes too, where the icon color is different from white or black.

How should I proceed to add a setting in about:config ?

@media (-moz-bool-pref: "some.cool.setting.name"){
/* styles activated only when this cool named boolean setting is set to true */
}

It's a matter of a couple lines of css styles and adding a mention in the README. For now, you can just replace the variable value as you did before until I release an update.

Reyshyram commented 4 months ago

Thank you, is it okay like this for a temporary method?

Naezr commented 4 months ago

https://github.com/Naezr/ShyFox/commit/55cc03617c4e119691f5096df1947a9e118bae8a

I'll add this to the parameter table in the README later. The nightly branch is far from being ready to be the next update anyway.

Reyshyram commented 4 months ago

Okay, I suppose I can close this now?