Browser alerts are broken

Naezr / ShyFox

A very shy little theme that hides the entire browser interface in the window border

Mozilla Public License 2.0

1.69k stars 31 forks source link

Browser alerts are broken #80

Closed sounak-kun closed 4 months ago

sounak-kun commented 4 months ago

First of all, amazing theme. Been using it for months, and it's genuinely the best CSS theme I've ever used.

Onto the bug, browser alerts are broken. They have been for quite some time, so it's not a regression.

Steps to reproduce:

Open Devtools
Type alert("Some text here")
The alert will show up but there will be no text

Platform:

Linux - Fedora 40 Gnome 46 Wayland

Naezr commented 4 months ago

First of all, amazing theme. Been using it for months, and it's genuinely the best CSS theme I've ever used.

Glad to hear it.

Linux - Fedora 40 Gnome 46 Wayland

I am using the same system, btw

https://github.com/Naezr/ShyFox/blob/b3e572b18f7a35abadf7d3072d369feec903e131/chrome/ShyFox/shy-global.css#L184

I was adding this line to move the extension removal confirmation dialog a little lower, and it turns out it moved the alerts text as well. The fix has been uploaded

Change .dialogBox to #window-modal-dialog manually to avoid downloading all the files again

sounak-kun commented 4 months ago

Thanks for the quick response! Just pulled the update (I have it set up as a git clone, so I don't have to download all the files). A little bit of text is still cut off, but the message is easily visible now. Thanks!

Glad to meet a fellow Fedora user!

Naezr commented 4 months ago

A little bit of text is still cut off

The fix is already in the nightly branch. I don't think it's worth disturbing the main branch for the sake of it. It will go there as part of a bigger update