search

Naezr / ShyFox

A very shy little theme that hides the entire browser interface in the window border
Mozilla Public License 2.0
1.69k stars 31 forks source link

Request - PopUp windows (like login screens for plex and paypal) have the 'open sidebar' error message on them #93

Closed nirurin closed 4 months ago

nirurin commented 4 months ago

When there is a login screen popup window, such as for logging into paypal or plex, it has the 'open sidebar' error message splashed onto it.

Not a huge deal, but thought I would mention it in case there was an easy way to have it not happen for those kinds of small popup windows.

Screenshot 2024-07-17 174637

Naezr commented 4 months ago

Most likely fixed in the nightly branch

Naezr commented 4 months ago

Is this issue still here?

nirurin commented 4 months ago

I just exchanged out the user.js and chrome folder for the ones in the nightly, and the sidebar message is still there for the login windows

Naezr commented 4 months ago

These popups are actually very hard to test. Do you know any site where you can call such windows? That would be helpful. I used to test this on “login with google”, but they changed the login method to a full tab.

nirurin commented 4 months ago

I know it happens with some PayPal payment checkouts. I have been testing it on my overseerr setup as that uses a plex login which pops up like that. Maybe a site which requires 2fa? As the phone code window is usually a pop up too. Github would be my first thought.

If you can't find one I can send the link to my overseerr later, but I'd rather dm it than write it in a public forum as its hosted on my own server. Should work as a last resort though if none of the others work for you.

On Fri, 19 Jul 2024, 08:45 Naѣzr, @.***> wrote:

These popups are actually very hard to test. Do you know any site where you can call such windows? That would be helpful. I used to test this on “login with google”, but they changed the login method to a full tab.

— Reply to this email directly, view it on GitHub https://github.com/Naezr/ShyFox/issues/93#issuecomment-2238572666, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4T22KN3HVPF7JI7SOAWB3ZNC73NAVCNFSM6AAAAABLBAQPQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZYGU3TENRWGY . You are receiving this because you authored the thread.Message ID: @.***>

Naezr commented 4 months ago

https://github.com/Naezr/ShyFox/commit/ca97fe736201fc18e3740b64716275da0aee5b6a#diff-65ba196e048edfca7814c48020b5bce5aea31953a537c6ff8cf072c733aa4aa9

That should fix the issue

nirurin commented 4 months ago

Tested it, worked on the overseerr window, so I'd say that's fixed now :)