allocator: rename to avoid shadow warning - Githubissues

Naios / function2

Improved and configurable drop-in replacement to std::function that supports move only types, multiple overloads and more

http://naios.github.io/function2

Boost Software License 1.0

539 stars 47 forks source link

allocator: rename to avoid shadow warning #47

Closed dowens-pp closed 2 years ago

dowens-pp commented 2 years ago

@Naios

rename 'allocator' --> '_allocator' to prevent shadowing gcc declaration.

What was a problem?

Addresses item #2 in https://github.com/Naios/function2/issues/30

How this PR fixes the problem?

renames 'allocator' to '_allocator' to avoid redeclaration warning

Check lists (check `x` in `[ ]` of list items)

[ ] Additional Unit Tests were added that test the feature or regression
[ ] Coding style (Clang format was applied)

Additional Comments (if any)

no functional changes, only warning elimination when using gcc.

Naios commented 2 years ago

Thank you for your contribution.

I renamed the allocators to allocator_, leading underscore is usually a compiler reserved identifier: https://stackoverflow.com/a/228797/2303378