fix(hmac): only handle hmac when using public_key - Githubissues

NangoHQ / nango

A single API for all your integrations.

https://www.nango.dev

Other

4.83k stars 442 forks source link

fix(hmac): only handle hmac when using public_key #3011

Closed bodinsamuel closed 1 week ago

bodinsamuel commented 1 week ago

Describe your changes

Fixes https://linear.app/nango/issue/NAN-2196/hmac-issue-when-using-connect-ui

Only handle hmac when using public_key It was assumed to be one or the other, but due to legacy usage, customers can still be using HMAC while trying the Connect UI. So only checking when the authMode is not session token.
Simplify HMAC service to accept DBEnvironment and save a lot of useless DB queries (about 20/hours lol but still)
Fix postSignature that was merged at the same time of my refactor and was not following the same pattern

linear[bot] commented 1 week ago

NAN-2196 HMAC issue when using connect ui