search

Nasiff / Online-Book-Store

An online book store that allows users to login, view and buy books.
2 stars 0 forks source link

fix: added missing price to BookBean, BookDAO, BookController #45

Closed patrickt416 closed 4 years ago

Nasiff commented 4 years ago

You mention that you're just updating the price but there are like 700 lines of change in this PR. Was that the intention?

patrickt416 commented 4 years ago

You mention that you're just updating the price but there are like 700 lines of change in this PR. Was that the intention?

It's because it's comparing it to previous version before we merged into main. What I have now in issue-24 includes the changes that were merged iinto main just recently.

Nasiff commented 4 years ago

You mention that you're just updating the price but there are like 700 lines of change in this PR. Was that the intention?

It's because it's comparing it to previous version before we merged into main. What I have now in issue-24 includes the changes that were merged earlier.

Ahh makes sense.

patrickt416 commented 4 years ago

Looks good to me, I see the prices being added to the service and the updated sql for the database. Also looks like it includes an update for customer reviews if I'm correct?

It does include update for customer reviews, but it's the same update from me that was merged to main just earlier today. lol It picked up on all of it, but the only real change is the price thing.