Concept Page for Skosmos 3

[joelit]

Description of the enhancement

This issue is for making sure the initial version of the concept page fulfills common requirements. It's OK if not all functionality is implemented.

• [x] Layout follows the static example
  • [x] Main .twig -template exists
  • [x] concept-info.inc exists
  • [x] sidebar.inc exists
  • [x] cypress tests exist

[osma]

Layout differs from the static example quite a bit.

[osma]

I've started reworking the concept page template on the branch issue1484-concept-page-templates-cypress. There is still a lot to do, but here is a list of requirements for the concept page, based in part on examining the old Twig template:

• [ ] for deprecated concepts, show an alert + add a CSS class used for styling (e.g. for greying out)
• [ ] message "no term for this concept in this language"
• [x] show breadcrumbs at top
• [ ] in place of normal prefLabel property name ("Preferred term"), show preferredSubpropertyLabel or custom_label
• [ ] show notation code next to prefLabel heading
• [ ] integer notation codes should not break, see #1381
• [ ] SKOS XL info & tooltip for prefLabel heading
• [ ] language tag next to prefLabel if applicable (e.g. explicit_langcodes is set)
• [x] copy to clipboard functionality for prefLabel
• [ ] copy to clipboard functionality for notation if available
• [ ] copy to clipboard buttons should show a message (e.g. "URI copied to clipboard"), like GitHub
• [x] copy to clipboard button should not wrap to next line if it can be avoided
• [x] hide subproperties of skos:hiddenLabel
• [ ] custom labels for properties
• [ ] property labels should be capitalized
• [ ] property values (e.g. skos:related with many values) should be sorted using locale-specific collation rules
• [x] properties with resource values (e.g. skos:broader):
  • [ ] show external vocabulary specifier, if applicable
  • [ ] special treatment for reified definitions (e.g. show tooltips with extra information)
  • [x] show notation code next to label if applicable
  • [ ] show language tag next to value if applicable (e.g. explicit_langcodes is set)
  • [ ] show submembers when applicable (for ThesaurusArrays such as "clothes by time of year")
  • [ ] if suitable label not found, display label in another language, or shortened URI if all else fails
  • [ ] special treatment for concept type
  • [ ] type should not be a link
  • [ ] type should be translated (e.g. skos:Collection, iso-thes:ConceptGroup)
  • [ ] don't show type if it's just skos:Concept
• [x] properties with literal values (e.g. skos:note)
  • [ ] show SKOS XL labels & extra information (e.g. tooltips)
  • [x] show values with HTML content
  • [x] show altLabels in italic
  • [ ] language tag next to value if applicable (e.g. explicit_langcodes is set)
  • [ ] show data types
  • [ ] format date property values such as xsd:date and xsd:dateTime according to the content language (or UI language?)
• [ ] truncate property value lists that are longer than set number of items with "show all X values" button
• [x] foreign labels (pref & alt)
  • [ ] show SKOS XL labels & extra information (e.g. tooltips)
  • [x] show foreign language altLabels in italic
• [x] show URI
• [x] copy to clipboard functionality for URI (inc. button)
• [x] download links
  • [ ] bottom of download icon should be aligned with text baseline
• [x] created & modified date
• [ ] make sure all values in the content language (as well as foreign labels) have appropriate language attributes in HTML, for e.g. screen readers
• [x] use h1/h2/h3... heading levels
• [ ] enable Axe accessibility tests and make sure they pass
• [ ] check responsiveness
• [ ] refactor: rename CSS class termpage to something more appropriate, e.g. concept-page (needs to be done globally)
• [ ] refactor: generate download URLs in PHP code, not in Twig template
• [ ] Mappings
  • [x] CSS(?) bugfix: when opening concept from the alphabetical index on vocabulary home page, the mappings should be displayed with a white background, just like when opening the concept page directly via URL.
  • [x] show a spinner while mappings are loading
  • [ ] show notation codes next to concepts in mappings

[joelit]

Further additions to the requirement spec could be:

• Formatting property values such as xsd:date and xsd:dateTime according to the content language

• Truncating property value lists that are longer than set number of items with "show all X values" -button as was done back in the day in #969

  There's also one relevant open issue for 3.0 (#1538 ) for an enhancements to the concept page, that's relevant to the requirement list.

[osma]

• Formatting property values such as xsd:date and xsd:dateTime according to the content language
• Truncating property value lists that are longer than set number of items with "show all X values" -button as was done back in the day in #969

Thanks, I added these to the checklist above (with minor editing). I'm not sure if the content language is the right choice here for date values, so I kept both options.

There's also one relevant open issue for 3.0 (#1538 ) for an enhancements to the concept page, that's relevant to the requirement list.

Good point, but implementing that one goes much deeper than just the concept page template + JS + styles, and we already have a separate issue about it, so let's keep it filed there.