NatashaTheRobot / TweetieTweet

Simple Android Twitter Client
1 stars 0 forks source link

[Android Bootcamp] - Advanced Twitter Client #1

Open NatashaTheRobot opened 10 years ago

NatashaTheRobot commented 10 years ago

@nesquena @timothy1ee - still trying to understand abstract classes - How would I refactor the UserTimelineFragment? Not sure how to use interfaces - need to look more into that as well!

nesquena commented 10 years ago

Hey Natasha, will do a full code review soon. If you want to stay a bit after class, might be a bit easier to show you some refactoring options in person. In short, there are approaches where you can move everything into the base class including for UserTimeline but they might require loading the user fragment dynamically (at runtime passing in the user as an argument) rather than statically (in the xml). Also, consolidating the initial load method and the paginating method (since there's only a few differences such as the lastTweetId) to cleanup the base class. We can chat more in person before or after class tomorrow if you'd like me to walk you through in more detail.

nesquena commented 10 years ago

:+1: nice work overall. A few notes after checking out the code:

Here's a detailed Project 4 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.

This week (Week 5), we are going to cover the last major piece to the Android puzzle and that is using the hardware and SDK components such as the camera, photo gallery, location, maps, etc. After that, Week 6 and week 7 we will be covering a few important intermediate topics such as more about styling and animation as well as testing.

Week 9 (March 10th), we are going to have a demo day to celebrate the progress you've all made with our next batch of Android students and multiple companies attending to see the group projects