search

NationStates / NationStatesPlusPlus

NationStates++ improves & rewrites the look and feel of nationstates.net - providing players with easy to use tools and more data to make decisions.
MIT License
22 stars 18 forks source link

Duplicate Challenge Tab #19

Closed NoxxFlame closed 9 years ago

NoxxFlame commented 9 years ago

With the 'Rift' theme I can see two challenge buttons. One seems to be a default NS one as when I disable NS++ it remains however the other has a different icon and sly appears when NS++ is enabled. image

Afforess commented 9 years ago

Confirming this is the case in the rift theme.

NoxxFlame commented 9 years ago

Also I know it is something small but while we are on the topic of the rift navigation bar the spacing on the NS++ icons are off when compared to the default icons. The World Assembly icon has wider padding and the NSWiki icon has almost no padding. Its something little I know but it just looks a but off.

Afforess commented 9 years ago

@nickpops98 The rift nav bar spacing has been fixed.

Afforess commented 9 years ago

I am not seeing the duplicate challenge icon anymore. Did NS only briefly have the icon?

Eluvatar commented 9 years ago

Not all that briefly, but it has indeed been removed.

On Sun, Feb 1, 2015 at 12:05 AM, Afforess notifications@github.com wrote:

I am not seeing the duplicate challenge icon anymore. Did NS only briefly have the icon?

— Reply to this email directly or view it on GitHub https://github.com/NationStates/NationStatesPlusPlus/issues/19#issuecomment-72351894 .

NoxxFlame commented 9 years ago

I don't think it has been removed as I can still see it. The default NS challenge button only appears when you are on someone else's nation page. If you are on your own page it does not show up.

Afforess commented 9 years ago

I don't see it on other nation's pages either.