search

NativeScript / nativescript-ui-charts

NativeScript wrapper around HiCharts library
Apache License 2.0
26 stars 6 forks source link

Updated angular demo, fixed the js to primitive function on ios for b… #11

Closed alexgritton closed 3 years ago

alexgritton commented 4 years ago

What is the current behavior?

  1. The angular demo app won't build and run.
  2. When running the angular demo app on an iPhone, or another app with the plugin installed, the app crashes when trying to view the Basic Line Chart (async data).

What is the new behavior?

  1. Updated the angular demo app to run on ios 14 and xcode 12.
  2. The fromJSToNativePrimitive(value) helper function wasn't translating booleans into numbers, which is expected by the api, causing the app to crash on iPhones. I've updated that function to return a number for booleans which prevents the app from crashing.

Fixes #5

shiv19 commented 3 years ago

@alexgritton Thank you!