search

NatronGitHub / openfx-arena

Extra OpenFX plugins for Natron
Other
41 stars 11 forks source link

ReadMisc/TestImagePCX fails #14

Open devernay opened 3 years ago

devernay commented 3 years ago

it gives a black image on linux and macOS It was working OK in Natron 2.2.9

rodlie commented 3 years ago

Will take a look after work today.

rodlie commented 3 years ago

convert from the SDK is able to convert PCX, but reading a PCX in Natron results in a black image. If I build ReadMisc against system ImageMagick (6.9.10-23) then Natron reads the PCX file just fine.

devernay commented 3 years ago

https://github.com/NatronGitHub/Natron/blob/RB-2.3/tools/jenkins/include/patches/ImageMagick/ImageMagick-6.9.10-gimp210.diff ?

devernay commented 3 years ago

I guess this is what breaks PCX

rodlie commented 3 years ago

Changes in XCF does not break PCX.

devernay commented 3 years ago

ah yes I mixed the letters ;-)

devernay commented 3 years ago

Makes me think we could ship the IM utilities with Natron, just as we ship the oiio ones.

rodlie commented 3 years ago

Can't hurt.

I will try to find why PCX fails, but to be honest, does anyone care? it's an old relic from the DOS era, superseded by BMP.

devernay commented 3 years ago

Makes me think we could ship the IM utilities with Natron, just as we ship the oiio ones.

And it would be even easier with IM7, which I think has only one utility (magick).

I'm OK if you disable PCX support in Natron (either at compile time or at run time)

rodlie commented 3 years ago

which I think has only one utility (magick).

Correct, you only need to prefix commands with magick.

magick convert, magick identify etc.

I'm OK if you disable PCX support in Natron (either at compile time or at run time)

Can do.

devernay commented 3 years ago

perhaps this has to do with the fact that your system IM has different HDRI/depth settings than Natron's?

rodlie commented 3 years ago

I tried Q16 with and without HDRI, same result. Can try with Q8.