Naxela / The_Lightmapper

Fast and easy baked GI Lightmaps for Blender and Cycles
GNU General Public License v3.0
719 stars 53 forks source link

strange artifacts with denoise activated #169

Closed dirkk0 closed 1 year ago

dirkk0 commented 1 year ago

Hi!

First of all - thank you for this tool, it's fantastic!

Then: I experimentally switched from Blender 3.3 to the latest 3.5.1. The good news is - it still works! The not so good news is: activating the integrated denoiser results in (presumably) mixed up images, like so: 2023-04-28_16-00

Without the denoiser, it looks like that: 2023-04-28_16-01

Doing the same in Blender 3.3 (add plane and icosphere, acivate lightmapper for the whole scene, add denoise) works perfectly.

I wonder why that is?

Thanks again, Dirk

PS: I can provide the files if needed.

Naxela commented 1 year ago

Hi, thanks for checking this out. There definitely seems to be a bug with the internal denoiser (they've probably changed something between 3.3 and 3.5 related to the compositor). In the meantime, can you check if manually using OIDN works? (Package from here: https://github.com/OpenImageDenoise/oidn/releases)

Thanks again!

Naxela commented 1 year ago

Hi again, I think I might have fixed the issue now - Could you test if it works for you now?

Thanks

dirkk0 commented 1 year ago

.. man, you're fast! :) I will test as soon as I'm back on my machine! thanks!

dirkk0 commented 1 year ago

works like a charm! thanks!

victorbnl commented 1 year ago

I had this issue as well. If OIDN can be used as a workaround, shouldn’t this issue be kept open to further investigate on why Blender’s standard denoiser acts like that, and what should be done in consequence?