Closed Ry-DS closed 1 year ago
Thanks!
In hindsight, removing the explicit keyword here: https://github.com/Neargye/magic_enum/blob/fd9f70b91d04bf090699a4000b5d8b77781d125a/include/magic_enum_containers.hpp#L535 might have made more sense. Regardless either solution works, thanks for the prompt merge + release! :raised_hands:
Yes, perhaps this fix makes sense, in the original bitset it is not marked explicit https://en.cppreference.com/w/cpp/utility/bitset/reference
If you have time, I will be glad to accept PR
was about to make one but I see it's handled in 677636ec430912e75f07554259de6331660d8fc7, thanks!
The erase function does not compile on the following:
When building for C++ 17 and 20 (note these specific configurations are all I tested).
Compile error:
This PR fixes that, while adding tests for this function to ensure this template is instansiated and exercised.