PR to track downstream changes in a fork

Nebo15 / ecto_trail

EctoTrail allows to store Ecto changeset changes in a separate audit_log table.

https://hex.pm/packages/ecto_trail

MIT License

54 stars 5 forks source link

PR to track downstream changes in a fork #12

Open AndrewDryga opened 5 years ago

coveralls commented 5 years ago

Coverage remained the same at 96.154% when pulling e179f9b3fcfe7fd2e9f0fb44cca207e2b633be1f on valiot:master into d6f69c89a4609d228591c79abc8988ec339f377a on Nebo15:master.

acrogenesis commented 5 years ago

Hello @AndrewDryga, at Valiot we are actively maintaining and adding features to ecto_trail as we are using it in our core product. If you like we can take over it. You can take a look at our fork here: https://github.com/valiot/ecto_trail/

We've also been thinking in renaming it so we can publish updated versions to hex.pm

What do you think?

PavelVesnin commented 5 years ago

Hi @acrogenesis . Create PR with your changes and we can publish it

AndrewDryga commented 5 years ago

I think it would be nice if we collaborate on improving it instead of maintaining two separate versions. I'm even totally okay to give you write access and rights to publish on Hex, if we agree to not introduce breaking changes (because it's used in our production too).

AndrewDryga commented 5 years ago

Ebert has finished reviewing this Pull Request and has found:

5 possible new issues (including those that may have been commented here).

But beware that this branch is 1 commit behind the Nebo15:master branch, and a review of an up to date branch would produce more accurate results.

You can see more details about this review at https://ebertapp.io/github/Nebo15/ecto_trail/pulls/12.