NebulaSS13 / Nebula

A general purpose SS13/Baystation12 fork.
https://discord.gg/Ddw58yF
GNU Affero General Public License v3.0
52 stars 220 forks source link

Radial menu issues #4362

Closed OlyMoley7 closed 2 months ago

OlyMoley7 commented 3 months ago

Description of issue

Radial menus don't work as intended, random choice instead of the option picked or nothing at all

Difference between expected and actual behavior

Click on toggle safety, does nothing Click on suture artery, has a 1 in (however many options there are in the menu) chance of doing what was issued, will either sew the wound back together, suture an artery or link tendons

Steps to reproduce

Open a radial menu and interact with it.

Specific information for locating

Length of time in which bug has been known to occur

Client version, Server revision & Game ID

Issue bingo

MistakeNot4892 commented 3 months ago

Regarding the surgery issue, do you have surgery skills selected? Toggling safety worked fine on Neb dev a few hours ago when I did the fix for unloading.

MistakeNot4892 commented 3 months ago

Seems like I clobbered gun changes after testing, #4367 fixes the alt interaction. Surgery stuff seems to be skill related, cannot reproduce your issue except with untrained Anatomy or Medicine, which is an intentional consequence of a skill failure.

OlyMoley7 commented 3 months ago

Regarding the surgery issue, do you have surgery skills selected? Toggling safety worked fine on Neb dev a few hours ago when I did the fix for unloading.

This was seen with a character with trained anatomy and medical

MistakeNot4892 commented 3 months ago

Cannot reproduce this on Neb dev. Will need some more specific reproduction steps if they come up.

MistakeNot4892 commented 2 months ago

I think this may have been due to the UX issues with labels that are fixed on current dev. Going to call this closed for now, feel free to reopen with specific reproduction steps if it persists.