Nekmo / amazon-dash

Hack your Amazon Dash to run what you want.
MIT License
826 stars 69 forks source link

Provide custom success/failure messages #149

Open chrissv opened 4 years ago

chrissv commented 4 years ago

What is the purpose of your issue?

Description

Currently the text for the confirmation is either the output of the command, or a generic The {} device has been executed successfully. This enhancement is to provide custom success and failure text in the yml file for the confirmations, for example:

devices:
  78:e1:03:b5:44:aa:
    name: test_button
    cmd: some_command
    ssh: localhost
    confirmation: send-tg
    msg_success: {name} light is turned on
    msg_failure: Something bad happened with {name} - check log

(_msgsuccess and _msgfailure are the new parameters, as a suggestion)

In addition to the new messages, it would be nice to have some kind of primitive substitutions within the messages for things like the name, and maybe others that would make sense (such as date and time, and output from the cmd).

Nekmo commented 4 years ago

Added to milestone v1.5.0!

chrissv commented 4 years ago

Do you plan on adding any variable substitutions, like {name} and/or {date}? If so, which ones make sense?