search

Nemo157 / cargo-lichking

Automated license checking for rust. cargo lichking is a Cargo subcommand that checks licensing information for dependencies.
Other
127 stars 16 forks source link

WIP: Accept --target flag #41

Closed Nemo157 closed 11 months ago

Nemo157 commented 6 years ago

Will fix #39

thomcc commented 5 years ago

I rebased this at https://github.com/thomcc/cargo-lichking/tree/target-flag (and deleted the println's) and it seems to work (in some fairly limited tests, but enough for my uses).

Not sure what prevented this from landing

Nemo157 commented 5 years ago

I think the main thing I wanted to do was add tests for it, but the sheer amount of setup required to effectively test it was overwhelming. I was going to come back to do it, but then just didn't.

At this point, if it appears to be working for you feel free to open a new PR with the rebased changes and I'll merge it (and probably add some more text to the help saying that it's less guaranteed to work correctly).