search

NeonGeckoCom / neon_debos

Debos build files for Neon OS
Apache License 2.0
1 stars 8 forks source link

[BUG] Neon OS Release 24.07.24 - wallpaper not rotating #164

Closed Olzeke51 closed 4 months ago

Olzeke51 commented 4 months ago

Description

Even though gui/settings/display/wallpaper rotation is set to 'ON' ; there is no rotation secondly) turning that setting to OFF , backing out, then going in - setting is ON - won't hold selected OFF

Steps to Reproduce

No response

Relevant Code

gui.log from support/troubleshooting package sent to 'support' jul 24_8:57 EDT gui_log.txt

Other Notes

this is in my neon.yaml

PHAL:
  ovos-PHAL-plugin-wallpaper-manager:
    module: ovos-PHAL-plugin-wallpaper-manager
    wait_for_gui: false
    lang: en-us
    selected_provider: skill-ovos-homescreen.openvoiceos
NeonDaniel commented 4 months ago

Looks like that's been fixed but not yet made it into a stable release (https://github.com/OpenVoiceOS/ovos-PHAL-plugin-wallpaper-manager/compare/0.0.1...0.0.2a7).

@jarbasal @mikejgray I think that package is ready for a stable release; thoughts?

mikejgray commented 4 months ago

Don't see why not. No open issues, and it's been in regular use since last year. Sounds stable enough to me!

NeonDaniel commented 4 months ago

0.0.2, 0.1, or 1.0? It contains breaking changes, but I don't believe behavior is changed (other than bugs being fixed).

I think 0.1.0 is most consistent with other packages, but I have no strong preference.

mikejgray commented 4 months ago

No strong preference either, probably best to stay consistent with 0.1.0

NeonDaniel commented 4 months ago

Marking as invalid not because the issue isn't valid, but because this regression is from the later beta releases and not the previous stable release.

No strong preference either, probably best to stay consistent with 0.1.0

https://github.com/OpenVoiceOS/ovos-PHAL-plugin-wallpaper-manager/pull/15