NeonGeckoCom / skill-weather

Mycroft AI official Weather Skill, providing weather conditions and forecasts.
https://mycroft.ai/skills
Apache License 2.0
1 stars 1 forks source link

[BUG] Incorrect sunset time #47

Closed strugee closed 6 months ago

strugee commented 1 year ago

Description

Mycroft claims the sunset will be at "quarter past three today" when it's actually around 8:15 PM.

Steps to Reproduce

Relevant Code

No response

Other Notes

Neon version: 23.7.26a1 on a Mark II enclosure

Logs from the most recent time I ran this:

$ tail -fn0 *.log
==> admin.log <==

==> audio.log <==

==> bus.log <==

==> enclosure.log <==

==> gui.log <==

==> neon-utils.log <==

==> skills.log <==

==> voice.log <==
2023-07-29 16:03:35.897 - voice - ovos_utils.file_utils:resolve_resource_file:152 - WARNING - Deprecation version=0.1.0. Caller=ovos_dinkum_listener.service:500. Expected a dict config and got None.
2023-07-29 16:03:36.857 - voice - ovos_dinkum_listener.voice_loop.voice_loop:run:205 - INFO - Wakeword detected
2023-07-29 16:03:41.142 - voice - ovos_dinkum_listener.voice_loop.voice_loop:run:235 - INFO - speech finished
2023-07-29 16:03:41.248 - voice - ovos_dinkum_listener.voice_loop.voice_loop:_after_cmd:640 - INFO - transcribed: when does the sun set

==> skills.log <==
2023-07-29 16:03:42.171 - skills - neon_core.skills.intent_service:handle_utterance:225 - INFO - ['when does sun set', 'when does the sun set']
2023-07-29 16:03:45.382 - skills - skill_weather:_speak_weather:1262 - INFO - Speaking dialog: current-sunset-future-local

==> audio.log <==
2023-07-29 16:03:45.753 - audio - ovos_audio.service:execute_tts:319 - INFO - Speak: the sun will go down at quarter past three today
2023-07-29 16:03:45.818 - audio - neon_audio.tts.neon:get_requested_tts_languages:75 - INFO - Got profiles: [{'user': {'first_name': 'Aj', 'middle_name': '', 'last_name': '', 'preferred_name': 'Aj', 'full_name': 'Aj', 'dob': 'YYYY/MM/DD', 'age': '', 'email': '', 'username': 'local', 'password': '', 'picture': '', 'about': '', 'phone': '', 'phone_verified': False, 'email_verified': False}, 'brands': {'ignored_brands': {}, 'favorite_brands': {}, 'specially_requested': {}}, 'speech': {'stt_language': 'en-us', 'alt_languages': [], 'tts_language': 'en-us', 'tts_gender': 'female', 'neon_voice': '', 'secondary_tts_language': '', 'secondary_tts_gender': 'male', 'secondary_neon_voice': '', 'speed_multiplier': 1.0}, 'units': {'time': 24, 'date': 'MDY', 'measure': 'imperial'}, 'location': {'lat': 40.7896239, 'lng': -73.9598939, 'city': 'New York', 'state': 'New York', 'country': 'United States', 'tz': 'America/New_York', 'utc': -5.0, 'country_code': 'us'}, 'response_mode': {'speed_mode': 'quick', 'hesitation': False, 'limit_dialog': False}, 'privacy': {'save_audio': True, 'save_text': True}}]
2023-07-29 16:03:45.831 - audio - neon_audio.tts.neon:_get_tts:216 - INFO - Legacy Neon TTS signature found
2023-07-29 16:03:45.834 - audio - neon_audio.tts.neon:_get_tts:225 - INFO - Using cached TTS audio
2023-07-29 16:03:45.838 - audio - ovos_plugin_manager.templates.tts:run:245 - WARNING - it seems you interfacing with TTS.queue directly, this is not recommended!
new expected TTS.queue contents -> data, visemes, listen, tts_id, message
2023-07-29 16:03:49.670 - audio - neon_audio.tts.neon:_play:156 - INFO - Played 1690671825.3948278
NeonDaniel commented 8 months ago

This same issue was reported on the forum. The user there noted that changing the system timezone resolved the issue, so it appears that something in the skill is using system time instead of epoch time to parse the formatted time.