Not working on Gnome 3.32

Neroth / gnome-shell-extension-weather

A simple extension for displaying weather informations from several cities in GNOME Shell

GNU General Public License v3.0

138 stars 143 forks source link

Not working on Gnome 3.32 #250

Open Abhinav1217 opened 5 years ago

Abhinav1217 commented 5 years ago

I am getting following error on Solus 4 Gnome 3.32.1


TypeError: GWeather.Location.new_world is not a function

Stack trace:
  @/home/abhinav/.local/share/gnome-shell/extensions/weather-extension@xeked.com/prefs.js:100:10
  _getExtensionPrefsModule@resource:///org/gnome/shell/extensionPrefs/main.js:59:13
  _selectExtension@resource:///org/gnome/shell/extensionPrefs/main.js:74:31
  _onCommandLine@resource:///org/gnome/shell/extensionPrefs/main.js:320:17
  main@resource:///org/gnome/shell/extensionPrefs/main.js:635:5
  @<main>:1:43

Reinis commented 5 years ago

@Neroth In my fork, I have brushed up the extension to work with Gnome 3.32 (should still work with older ones, too, at least a couple versions back); this should fix issues #251 #249 #248 #245:

Reformat and refactor according to Gnome Shell coding style
Use ES6 classes and arrow functions
Add support for variable timer interval (after failed update it retries every 30s for up to 5min, by default — every 5min)
Fix a bunch of crashes and other misc improvements

HinTak commented 4 years ago

It seems to work much better with gnome-shell 3.34 (no code change in the weather extension, I just upgraded from fedora 30 to 31). I'd still like to know what's broken with gnome-shell 3.32 to cause the #249 .