Netflix / lemur-docker

Docker files for the Lemur certificate orchestration tool
170 stars 88 forks source link

add makefile #57

Closed sergerdn closed 3 years ago

sergerdn commented 3 years ago

Changes:

I also created PR https://github.com/Netflix/lemur/pull/3389 to make sure that tests passed on:

jtschladen commented 3 years ago

Before I merge, I wanted to discuss the move of lemur to .lemur. One of my goals with re-writing this was to allow developers to make changes to the repo to test in a Docker container locally, rather than running directly on the host machine. Therefore, I don't necessarily consider the lemur repo to be just a build dependency - it's part of the core purpose of this Docker setup, and definitely would want to be used/viewed by someone running this. Therefore, I think I'd prefer to leave it as lemur rather than .lemur.

sergerdn commented 3 years ago

Before I merge, I wanted to discuss the move of lemur to .lemur. One of my goals with re-writing this was to allow developers to make changes to the repo to test in a Docker container locally, rather than running directly on the host machine. Therefore, I don't necessarily consider the lemur repo to be just a build dependency - it's part of the core purpose of this Docker setup, and definitely would want to be used/viewed by someone running this. Therefore, I think I'd prefer to leave it as lemur rather than .lemur.

Ok, agree.

jtschladen commented 3 years ago

Thanks @sergerdn !