Fix missing client metrics

Andyz26 commented 6 months ago

Context

The SSEWorkerConnection clients don't apply the client listener factory, thus missing certain metrics on the client side, e.g. tcpClient bytesRead.

The fix here is to re-apply the listener similar to how rxnetty clients got it.

Checklist

[ ] ./gradlew build compiles code correctly
[ ] Added new tests where applicable
[ ] ./gradlew test passes all tests
[ ] Extended README or added javadocs where applicable

github-actions[bot] commented 6 months ago

Test Results

517 tests ±0 511 :white_check_mark: ±0 7m 16s :stopwatch: -6s 134 suites ±0 6 :zzz: ±0 134 files ±0 0 :x: ±0

Results for commit 31579cc4. ± Comparison against base commit e3af4923.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 6 months ago

Uploaded Artifacts

To use these artifacts in your Gradle project, paste the following lines in your build.gradle.

resolutionStrategy {
    force "io.mantisrx:mantis-common-serde:0.1.0-20240514.000828-537"
    force "io.mantisrx:mantis-common:0.1.0-20240514.000828-537"
    force "io.mantisrx:mantis-discovery-proto:0.1.0-20240514.000828-537"
    force "io.mantisrx:mantis-client:0.1.0-20240514.000828-538"
    force "io.mantisrx:mantis-remote-observable:0.1.0-20240514.000828-538"
    force "io.mantisrx:mantis-network:0.1.0-20240514.000828-537"
    force "io.mantisrx:mantis-runtime-executor:0.1.0-20240514.000828-73"
    force "io.mantisrx:mantis-runtime:0.1.0-20240514.000828-538"
    force "io.mantisrx:mantis-shaded:0.1.0-20240514.000828-536"
    force "io.mantisrx:mantis-runtime-loader:0.1.0-20240514.000828-538"
    force "io.mantisrx:mantis-testcontainers:0.1.0-20240514.000828-207"
    force "io.mantisrx:mantis-connector-iceberg:0.1.0-20240514.000828-536"
    force "io.mantisrx:mantis-rxcontrol:0.1.0-20240514.000828-11"
    force "io.mantisrx:mantis-connector-kafka:0.1.0-20240514.000828-538"
    force "io.mantisrx:mantis-connector-publish:0.1.0-20240514.000828-537"
    force "io.mantisrx:mantis-control-plane-client:0.1.0-20240514.000828-537"
    force "io.mantisrx:mantis-control-plane-core:0.1.0-20240514.000828-531"
    force "io.mantisrx:mantis-control-plane-server:0.1.0-20240514.000828-531"
    force "io.mantisrx:mantis-examples-core:0.1.0-20240514.000828-531"
    force "io.mantisrx:mantis-examples-groupby-sample:0.1.0-20240514.000828-531"
    force "io.mantisrx:mantis-examples-jobconnector-sample:0.1.0-20240514.000828-531"
    force "io.mantisrx:mantis-connector-job:0.1.0-20240514.000828-538"
    force "io.mantisrx:mantis-examples-mantis-publish-sample:0.1.0-20240514.000828-531"
    force "io.mantisrx:mantis-examples-twitter-sample:0.1.0-20240514.000828-531"
    force "io.mantisrx:mantis-examples-sine-function:0.1.0-20240514.000828-531"
    force "io.mantisrx:mantis-examples-wordcount:0.1.0-20240514.000828-531"
    force "io.mantisrx:mantis-publish-core:0.1.0-20240514.000828-531"
    force "io.mantisrx:mantis-server-agent:0.1.0-20240514.000828-531"
    force "io.mantisrx:mantis-examples-synthetic-sourcejob:0.1.0-20240514.000828-531"
    force "io.mantisrx:mantis-publish-netty-guice:0.1.0-20240514.000828-531"
    force "io.mantisrx:mantis-source-job-kafka:0.1.0-20240514.000828-531"
    force "io.mantisrx:mantis-publish-netty:0.1.0-20240514.000828-530"
    force "io.mantisrx:mantis-source-job-publish:0.1.0-20240514.000828-531"
    force "io.mantisrx:mantis-control-plane-store-dynamodb:0.1.0-20240514.000828-25"
    force "io.mantisrx:mantis-server-worker-client:0.1.0-20240514.000828-531"
}

Netflix / mantis