Use XXH3 when hashing values for MantisGroups

Netflix / mantis

A platform that makes it easy for developers to build realtime, cost-effective, operations-focused applications

Apache License 2.0

1.42k stars 202 forks source link

Context

Uses the XXH3 hash function for hashing keys onto the ring. I incorrectly assumed that the uniformity assumption in both hash functions would make ketama hash correctly onto the XXH3 ring but that has not been what we're seeing.

@Andyz26 Heads up this fixes a critical bug in the last patch that we cut an RC for.

Checklist

[ ] ./gradlew build compiles code correctly
[ ] Added new tests where applicable
[ ] ./gradlew test passes all tests
[ ] Extended README or added javadocs where applicable

Test Results

539 tests ±0 533 :white_check_mark: ±0 7m 50s :stopwatch: +2s 139 suites ±0 6 :zzz: ±0 139 files ±0 0 :x: ±0

Results for commit 1b230591. ± Comparison against base commit c29dfa4a.

:recycle: This comment has been updated with latest results.

Netflix / mantis