search

Netflix / security_monkey

Security Monkey monitors AWS, GCP, OpenStack, and GitHub orgs for assets and their changes over time.
Apache License 2.0
4.35k stars 799 forks source link

Hardcoded reference to Riot Games #1223

Open blazingkin opened 5 years ago

blazingkin commented 5 years ago

https://github.com/Netflix/security_monkey/blob/4d198ad29b2f7a828ce130d222c6e76e71b9ce11/scripts/secmonkey_auto_install.sh#L606

Seeing as this is a netflix product, the only hardcoding I would expect would be for Netflix.

Either way. This should probably be configurable

mikegrima commented 5 years ago

That should be configurable. Please feel free to submit a PR to fix it.

Niladri24dutta commented 4 years ago

That should be configurable. Please feel free to submit a PR to fix it.

@mikegrima Can I create a PR for this? I think we can make it configurable by passing one extra argument like -o to mention the company name similarly what is being done for $website using positional parameter -w|--website . If the value is not set we can set it to some default value during the creation of ssl certificate. Let me know if my understanding is correct.

Niladri24dutta commented 4 years ago

@mikegrima here is the code which I am referring to https://github.com/Netflix/security_monkey/blob/4d198ad29b2f7a828ce130d222c6e76e71b9ce11/scripts/secmonkey_auto_install.sh#L167

sudo-ryan commented 4 years ago

https://github.com/Netflix/security_monkey/pull/1232 👍🏻