simple_vault test implementation

NethermindEth / StarknetByExample

A collection of examples of Cairo smart contracts for Starknet.

https://starknet-by-example.voyager.online/

MIT License

101 stars 77 forks source link

simple_vault test implementation #220

Open LamsyA opened 3 weeks ago

LamsyA commented 3 weeks ago

Issue(s): add tests https://github.com/NethermindEth/StarknetByExample/issues/70 for simple vault contract fixed all the issues and refactor the vault contract.

Description added test to the simple vault contract

Checklist

[x] CI Verifier: Run ./scripts/cairo_programs_verifier.sh successfully
[x] Contract Tests: Added tests to cover the changes

julio4 commented 3 weeks ago

Duplicate of #206?

LamsyA commented 3 weeks ago

Duplicate of #206?

Yeah, I was unable to remove the "commit reveal" commit from the PR. I had to create another PR which is this one.

julio4 commented 3 weeks ago

Duplicate of #206?

Yeah, I was unable to remove the "commit reveal" commit from the PR. I had to create another PR which is this one.

Ok, closing the other issue then.

LamsyA commented 3 weeks ago

Duplicate of #206?

Yeah, I was unable to remove the "commit reveal" commit from the PR. I had to create another PR which is this one.

Ok, closing the other issue then.

Okay.

Kindly review this new one.

I have fixed all the issue here.